feat: 🎸 throwAlertOnCancel control prop for SQFormDialog #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwAlertOnCancel allows the option to override the Are You Sure dialog when cancelling SQFormDialog while in the middle of filling out. Set to true and will throw alert by default (same as previous behavior). ✅ Closes: SelectQuoteLabs#806
|
This looks good! |
adds happy and sad path tests for throwAlertOnCancel ✅ Closes: SelectQuoteLabs#806
|
absolutely, just pushed up happy and sad tests! |
laurelbean
reviewed
Oct 4, 2022
fixes test description for second test of throwAlertOnCancel ✅ Closes: SelectQuoteLabs#806
laurelbean
approved these changes
Oct 4, 2022
aharpt
approved these changes
Oct 5, 2022
20BBrown14
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throwAlertOnCancel allows the option to override the Are You Sure dialog when cancelling SQFormDialog while in the middle of filling out. Set to true and will throw alert by default (same as previous behavior).
✅ Closes: #806
loom video! https://www.loom.com/share/5f77ebacb0c049c2973b1135ce0bd60d