Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Component to force user date selection via DatePicker #80

Merged
merged 6 commits into from
Jan 20, 2021

Conversation

SeanGroff
Copy link
Contributor

The SQFormDatePickerWithCalendarInputOnly component disables the text
input forcing the user to make a date selection via the picker. Also
allows the consumer of SQFormDatePicker the ability to disable any(s) in
the calendar view. See Issue 74 for more information.

Loom

The issue also unblocks AZT-1451 on the Senior CRM

Closes: #74

The SQFormDatePickerWithCalendarInputOnly component disables the text
input forcing the user to make a date selection via the picker. Also
allows the consumer of SQFormDatePicker the ability to disable any(s) in
the calendar view.

✅ Closes: #74
@SeanGroff SeanGroff requested a review from a team January 19, 2021 22:53
@@ -61,9 +64,9 @@ function SQFormDatePicker({
{...inputProps}
name={name}
color="primary"
disabled={isDisabled}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant and doesn't do anything so removed it.

@caleboleary
Copy link

Nice work Sean, and thanks for providing examples. One non-blocker nit - might be good to mention in the proptypes that the setDisabledDate is just a predicate which every rendered day is checked against. Took me looking at your examples to understand how to use that.

@SeanGroff
Copy link
Contributor Author

Nice work Sean, and thanks for providing examples. One non-blocker nit - might be good to mention in the proptypes that the setDisabledDate is just a predicate which every rendered day is checked against. Took me looking at your examples to understand how to use that.

100% agreed. I'll commit this change

@SeanGroff SeanGroff merged commit efa0420 into master Jan 20, 2021
@SeanGroff
Copy link
Contributor Author

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@20BBrown14 20BBrown14 deleted the DatePicker_Enhancements branch January 12, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker Enhancements
4 participants