Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQFormDatePicker Tests Update #876

Closed
Tracked by #358
aharpt opened this issue Apr 7, 2023 · 3 comments
Closed
Tracked by #358

SQFormDatePicker Tests Update #876

aharpt opened this issue Apr 7, 2023 · 3 comments
Assignees

Comments

@aharpt
Copy link
Contributor

aharpt commented Apr 7, 2023

No description provided.

@aharpt aharpt mentioned this issue Apr 7, 2023
13 tasks
@aharpt aharpt self-assigned this Apr 7, 2023
@aharpt
Copy link
Contributor Author

aharpt commented Apr 7, 2023

@laurelbean I have made a few adjustments, but just curious if you had anything specific in mind in terms of things you wanted to see changed on the DatePicker tests?

@laurelbean
Copy link
Contributor

There were a few test cases I couldn't get to work because for some reason Testing Library was interpreting the text box as a button. See my comment here: #265 (comment)

@aharpt
Copy link
Contributor Author

aharpt commented Apr 10, 2023

There were a few test cases I couldn't get to work because for some reason Testing Library was interpreting the text box as a button. See my comment here: #265 (comment)

@laurelbean Makes sense. Not super sure if breaking up that input as far as the roles go is doable at all. Looks like the "textbox" role is coming from the TextBox compononent from MUI. Since the calendar button is part of that TextField component, not super sure if we have any ability to do much with that. Below is a screenshot and the link that talks about this if interested.

Screen Shot 2023-04-10 at 9 22 39 AM

https://mui.com/material-ui/guides/testing/

I am still semi new to react-testing-library so maybe I am just missing something, but that is what it looks like to me.

aharpt pushed a commit that referenced this issue Apr 12, 2023
laurelbean pushed a commit that referenced this issue Jul 10, 2023
Closes: #876

Co-authored-by: Aaron Harpt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants