Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero value not showing in read only field #813

Closed
hvilander opened this issue Nov 4, 2022 · 0 comments · Fixed by #814
Closed

Zero value not showing in read only field #813

hvilander opened this issue Nov 4, 2022 · 0 comments · Fixed by #814
Assignees
@aharpt

Comments

@hvilander
Copy link
Contributor

If you want to display the number zero as a read only value it will not show in SQFormReadOnlyField because of this OR. https://github.com/SelectQuoteLabs/SQForm/blob/master/src/components/SQForm/SQFormReadOnlyField.tsx#L32

Zero could be a real value and should not be discarded.
@aharpt aharpt self-assigned this Nov 4, 2022
aharpt pushed a commit that referenced this issue Nov 4, 2022
fix: 🐛 ReadOnlyField didn't accept zero
ce356c4 
Fix Issue where ReadOnlyField Didn't accept Zero

✅ Closes: #813
@aharpt aharpt mentioned this issue Nov 4, 2022
Merged
aharpt pushed a commit that referenced this issue Nov 4, 2022
chore: 🤖 Allow values other than null/undefined
401ded7 
✅ Closes: #813
aharpt pushed a commit that referenced this issue Nov 4, 2022
chore: 🤖 Change logic for empty string
6eef00d 
✅ Closes: #813
kaylamc2 pushed a commit that referenced this issue Jan 20, 2023
@semantic-release-bot
chore(release): 10.0.2 [skip ci]
6ae1439 
### [10.0.2](v10.0.1...v10.0.2) (2023-01-20)

### Bug Fixes

* 🐛 ReadOnlyField didn't accept zero ([ce356c4](ce356c4)), closes [#813](#813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharpt aharpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 ReadOnlyField didn't accept zero SelectQuoteLabs/SQForm
2 participants
@hvilander @aharpt