SQFormDialogStepper, SQFormDialog add loading state the dialogs

[Chris-Boyle]

In our dialogs we are not currently handling loading state. There are times when we open the dialog and are not ready to render the components. In this scenario we should show a loading spinner until the consumer says it is not loading anymore. Currently a consumer can do this but it would make consumer code much cleaner to have the dialogs handle it.

I am proposing we show the Select Quote circles as a loading spinner.

[20BBrown14]

I am proposing we show the Select Quote circles as a loading spinner.

I suggest we allow the consumer to pass an optional loading component as well

[Chris-Boyle]

I am proposing we show the Select Quote circles as a loading spinner.

I suggest we allow the consumer to pass an optional loading component as well

I think we should probably solve for the 80% and just use our SelectQuote loading spinner for now until there is a request to allow consumers to define one.

[SeanGroff]

I can see this for the Stepper as it's more of an all in one solution.
I don't believe loading states are a concern of Dialogs though.

I think the first problem to solve is building a shared component that will take up 100% of the parent elements height and width. Then center the loading rings and below the rings an optional loading message. Then this styled loading component can be used anywhere without having to do something like

<Dialog>
  {isLoading ? <div style={loadingStyle}><LoadingSpinner /></div> : content}
</Dialog>

instead it would be:

{isLoading ? <LoadingSpinner /> : content}

Styling is already done for the consumer.

[SeanGroff]

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀