Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQFormHelperText to SQFormDialog footer #695

Closed
Ariel-Schnur-SQ opened this issue Jul 6, 2022 · 0 comments · Fixed by #696
Closed

Add SQFormHelperText to SQFormDialog footer #695

Ariel-Schnur-SQ opened this issue Jul 6, 2022 · 0 comments · Fixed by #696
Assignees
@aharpt

Comments

@Ariel-Schnur-SQ
Copy link

We have a need for displaying a warning to the user in the SQFormDialog footer so the ability to pass SQFormHelperText options would be dope

Screen Shot 2022-07-06 at 4 43 10 PM
@aharpt aharpt self-assigned this Jul 7, 2022
aharpt added a commit that referenced this issue Jul 7, 2022
@aharpt
feat: 🎸 Add code for HelperText component in inclusion list
6a217a1 
Fix issue due to HelperText breaking change

✅ Closes: #695
aharpt added a commit that referenced this issue Jul 7, 2022
@aharpt
chore: 🤖 Refactored code comment
1b79090 
Refactored code comment

✅ Closes: #695
aharpt added a commit that referenced this issue Jul 7, 2022
@aharpt
chore: 🤖 Fix prettier issues
bd403c9 
Hopefully fix prettier issues

✅ Closes: #695
@aharpt aharpt linked a pull request Jul 7, 2022 that will close this issue
feat: 🎸 Add HelperText option to Dialog footer #696
Merged
aharpt added a commit that referenced this issue Jul 7, 2022
@aharpt
chore: 🤖 Update SQFormHelperText code per PR feedback
b570931 
Update SQFormHelperText `isValid` code per PR feedback

✅ Closes: #695
aharpt added a commit that referenced this issue Jul 7, 2022
@aharpt
feat: 🎸 Add footer text option to Dialog
86c17ac 
Add helper text option to Dialog footer

✅ Closes: #695
ghost pushed a commit that referenced this issue Jul 7, 2022
@semantic-release-bot
chore(release): 9.4.0 [skip ci]
ca17ad6 
## [9.4.0](v9.3.0...v9.4.0) (2022-07-07)

### Features

* 🎸 Add footer text option to Dialog ([86c17ac](86c17ac)), closes [#695](#695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharpt aharpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 Add HelperText option to Dialog footer SelectQuoteLabs/SQForm
2 participants
@aharpt @Ariel-Schnur-SQ