Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQForm V8: SQFormDatePicker muiFieldProps does not take an onAccept prop #672

Closed
aharpt opened this issue Apr 15, 2022 · 0 comments · Fixed by #673
Closed

SQForm V8: SQFormDatePicker muiFieldProps does not take an onAccept prop #672

aharpt opened this issue Apr 15, 2022 · 0 comments · Fixed by #673
Assignees
@aharpt

Comments

@aharpt
Copy link
Contributor

aharpt commented Apr 15, 2022 •
edited
Loading

I am working on SQForm V8 migration on the AQE2 project. I ran into this issue with the muiFieldProps in the SQFormDatePicker component. See video below.

https://www.loom.com/share/e362fd34b3a94a709dcf65f547af34d0
@aharpt aharpt self-assigned this Apr 15, 2022
aharpt added a commit that referenced this issue Apr 15, 2022
@aharpt
fix: 🐛 Fix hole in BaseDatePickerProps
3c1ab77 
Fix hole in BaseDatePickerProps

✅ Closes: #672
aharpt added a commit that referenced this issue Apr 15, 2022
@aharpt
chore: 🤖 Fix import order change
598bc4c 
Fix accidental import order change

✅ Closes: #672
@aharpt aharpt mentioned this issue Apr 15, 2022
Merged
aharpt added a commit that referenced this issue Apr 18, 2022
@aharpt
chore: 🤖 'SQFormPickerProps' now extend 'BasePickerProps'
2f51dfe 
Fix 'SQFormPickerProps' to now extend 'BasePickerProps'

✅ Closes: #672
aharpt added a commit that referenced this issue Apr 18, 2022
@aharpt
chore: 🤖 Change 'import' to 'import type'
3c2aff6 
Change 'import' to 'import type'

✅ Closes: #672
ghost pushed a commit that referenced this issue Apr 18, 2022
@semantic-release-bot
chore(release): 8.1.2 [skip ci]
dd7fc89 
### [8.1.2](v8.1.1...v8.1.2) (2022-04-18)

### Bug Fixes

* 🐛 Fix hole in BaseDatePickerProps ([3c1ab77](3c1ab77)), closes [#672](#672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharpt aharpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 672/fix date picker type SelectQuoteLabs/SQForm
1 participant
@aharpt