Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormGuidedWorkflow tests - Fix JSS warnings #520

Closed
laurelbean opened this issue Jan 10, 2022 · 1 comment · Fixed by #523
Closed

SQFormGuidedWorkflow tests - Fix JSS warnings #520

laurelbean opened this issue Jan 10, 2022 · 1 comment · Fixed by #523
Assignees
@laurelbean
Labels
in progress

Comments

@laurelbean
Copy link
Contributor

Related to #458

When running tests for SQFormGuidedWorkflow, the following warnings are logged:
Warning: [JSS] Cannot set property 'parentStyleSheet' of undefined (SQFormGuidedWorkflow)
Warning: [JSS] Rule is not linked. Missing sheet option "link: true" (SQFormGuidedWorkflow)
@laurelbean laurelbean self-assigned this Jan 10, 2022
@laurelbean
Copy link
Contributor Author

The fix for this turns out to be in scplus-shared-components. I created a PR there: https://bitbucket.org/SelectQuote/scplus-shared-components/pull-requests/199/fix-expandingcard-fix-jss-warning-when
When that is merged, I will update the version here.

laurelbean pushed a commit that referenced this issue Jan 10, 2022
fix: 🐛 Update scplus-shared-component version
5800909 
Updating to the latest scplus-shared-component version to get the test
fixes for SQFormGuidedWorkflow tests. Also removed all the console.log
statements in the stories for SQFormGuidedWorkflow to further reduce
logs while testing.

✅ Closes: #520
@laurelbean laurelbean mentioned this issue Jan 10, 2022
Merged
20BBrown14 pushed a commit that referenced this issue Jan 12, 2022
@laurelbean
fix: 🐛 Update scplus-shared-component version (#523)
64763ee 
Updating to the latest scplus-shared-component version to get the test
fixes for SQFormGuidedWorkflow tests. Also removed all the console.log
statements in the stories for SQFormGuidedWorkflow to further reduce
logs while testing.

✅ Closes: #520

Co-authored-by: Laurel Bean <[email protected]>
ghost pushed a commit that referenced this issue Jan 12, 2022
@semantic-release-bot
chore(release): 7.0.3 [skip ci]
1227082 
### [7.0.3](v7.0.2...v7.0.3) (2022-01-12)

### Bug Fixes

* 🐛 Update scplus-shared-component version ([#523](#523)) ([64763ee](64763ee)), closes [#520](#520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelbean laurelbean

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Update scplus-shared-component version SelectQuoteLabs/SQForm
1 participant
@laurelbean