Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed prop type: justify of ForwardRef(Grid) is deprecated #499

Closed
laurelbean opened this issue Jan 6, 2022 · 0 comments · Fixed by #500
Closed

Fix failed prop type: justify of ForwardRef(Grid) is deprecated #499

laurelbean opened this issue Jan 6, 2022 · 0 comments · Fixed by #500
Assignees
@laurelbean
Labels
in progress

Comments

@laurelbean
Copy link
Contributor

Related to #458

The prop justify on <Grid> components was changed to be justifyContent. So all instances of justify on a Grid component need updating.
These logs were another one clogging up testing logs.
@laurelbean laurelbean self-assigned this Jan 6, 2022
laurelbean pushed a commit that referenced this issue Jan 6, 2022
fix: 🐛 Update deprecated justify prop for Grid
761cbed 
The justify prop on Grid components was renamed to justifyContent. After
updating that I noticed that SQFormDialogStepper had 2 new error logs.
So I added defaults for missing required props and added a type to the
children PropTypes.

✅ Closes: #499
@laurelbean laurelbean mentioned this issue Jan 6, 2022
Merged
ghost pushed a commit that referenced this issue Jan 6, 2022
@semantic-release-bot
chore(release): 6.2.1 [skip ci]
888d6fc 
### [6.2.1](v6.2.0...v6.2.1) (2022-01-06)

### Bug Fixes

* 🐛 Update deprecated justify prop for Grid ([761cbed](761cbed)), closes [#499](#499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelbean laurelbean

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Update deprecated justify prop for Grid SelectQuoteLabs/SQForm
1 participant
@laurelbean