Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormScrollableCard height prop should accept a string #475

Closed
20BBrown14 opened this issue Nov 23, 2021 · 0 comments · Fixed by #477
Closed

SQFormScrollableCard height prop should accept a string #475

20BBrown14 opened this issue Nov 23, 2021 · 0 comments · Fixed by #477
Assignees
@20BBrown14

Comments

@20BBrown14
Copy link
Contributor

Affected Components: SQFormScrollableCard

Currently the height prop (https://github.com/SelectQuoteLabs/SQForm/blob/master/src/components/SQFormScrollableCard/SQFormScrollableCard.js#L208) on SQFormScrollableCard only accepts a number. This should be changed to accept a number or string that values like 50%, 100vh and calc() don't cause proptype warnings.
20BBrown14 added a commit that referenced this issue Dec 13, 2021
@20BBrown14
fix: 🐛 SQFormScrollableCard height prop accepts string now
f22c3af 
SQFormScrollableCard height prop validation now accepts a string
considering that's how it was being used.

✅ Closes: #475
@20BBrown14 20BBrown14 mentioned this issue Dec 13, 2021
Merged
@20BBrown14 20BBrown14 self-assigned this Jan 4, 2022
20BBrown14 added a commit that referenced this issue Jan 5, 2022
@20BBrown14
fix: 🐛 SQFormScrollableCard height prop accepts string now
130a8bf 
SQFormScrollableCard height prop validation now accepts a string
considering that's how it was being used.

✅ Closes: #475
20BBrown14 added a commit that referenced this issue Jan 7, 2022
@20BBrown14
fix: 🐛 SQFormScrollableCard height prop accepts string now
97486ef 
SQFormScrollableCard height prop validation now accepts a string
considering that's how it was being used.

✅ Closes: #475
ghost pushed a commit that referenced this issue Mar 31, 2022
@semantic-release-bot
chore(release): 7.4.2 [skip ci]
a97457c 
### [7.4.2](v7.4.1...v7.4.2) (2022-03-31)

### Bug Fixes

* 🐛 SQFormScrollableCard height prop accepts string now ([97486ef](97486ef)), closes [#475](#475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 SQFormScrollableCard height prop accepts string now SelectQuoteLabs/SQForm
1 participant
@20BBrown14