Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormAutoComplete resets form state on blur #38

Closed
ghost opened this issue Dec 23, 2020 · 3 comments · Fixed by #42
Closed

SQFormAutoComplete resets form state on blur #38

ghost opened this issue Dec 23, 2020 · 3 comments · Fixed by #42
Labels
bug Something isn't working released

Comments

@ghost
Copy link

ghost commented Dec 23, 2020

After selecting a value in the autocomplete field the rest of the fields that were validated are reset. This causes required fields that were filled in to now show as needing to be touched again to be valid. This is affecting all consumers of the SQFormAutoComplete component (dialog forms and forms).

Steps to reproduce
Update the SQForm basic form example to have isRequired={true} on every field.
Fill out the fields and when you get to the autocomplete field take not of all the validated fields with the green check mark.
After leaving the auto complete field all fields that were validated will have their state reset to their initial state value.

Loom: https://www.loom.com/share/d7f51ceb423b45ed802851ca693f64af
@ghost ghost self-assigned this Dec 23, 2020
@ghost
Copy link
Author

ghost commented Dec 23, 2020 •
edited by ghost
Loading

I may start digging into this since it is currently blocking me.

@SeanGroff
Copy link
Contributor

I've noticed this as well. Certainly a bug.

@SeanGroff SeanGroff added the bug Something isn't working label Dec 23, 2020
ghost pushed a commit that referenced this issue Dec 29, 2020
@Chris-Boyle
fix: 🐛 Fixed onBlur event for autocomplete and touched fields
c62e313 
✅ Closes: #38
@ghost ghost mentioned this issue Dec 29, 2020
Merged
github-actions bot pushed a commit that referenced this issue Dec 29, 2020
@semantic-release-bot
chore(release): 2.0.3 [skip ci]
8a5227b 
### [2.0.3](v2.0.2...v2.0.3) (2020-12-29)

### Bug Fixes

* 🐛 Fixed onBlur event for autocomplete and touched fields ([c62e313](c62e313)), closes [#38](#38)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Fixed onBlur event for autocomplete and touched fields SQAH-1268 SelectQuoteLabs/SQForm
1 participant
@SeanGroff