Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQFormMultiSelect tooltip disable prop #313

Closed
jamesgriffith9519 opened this issue Jun 23, 2021 · 3 comments · Fixed by #397
Closed

SQFormMultiSelect tooltip disable prop #313

jamesgriffith9519 opened this issue Jun 23, 2021 · 3 comments · Fixed by #397
Assignees
Labels
enhancement New feature or request

Comments

@jamesgriffith9519
Copy link
Contributor

jamesgriffith9519 commented Jun 23, 2021

Component: SQFormMultiSelect : https://github.com/SelectQuoteLabs/SQForm/blob/master/src/components/SQForm/SQFormMultiSelect.js

I ran into a scenario when using the SQFormMultiSelect and specifically it's the on-hover tooltip that is displayed. When hovering over the input it displays the selected items and it does work, however, after your list of items grows the tooltip gets very large in size. I've attached a quick loom to demonstrate this here: https://www.loom.com/share/18e789906b58496c901926ecf581c66d

I don't think we would have giant lists selected too often but I know at times we may and the tooltip will likely get in the way for users, if we had a prop that would/could disable tooltip that might be preferred for SQFormMultiSelect instances that may have many options checked.

@lucas-homer
Copy link
Contributor

I'm curious why we even have a tooltip for this in the first place. Seems like overkill considering we show the selected items (though truncated) in a list in the input.

@lucas-homer
Copy link
Contributor

We faced this issue again :) I wish I could either:

  1. disable tooltip, or
  2. feed the component my own tooltip text, be it static or dynamic. In this case, I can provide informative text rather than listing potentially hundreds of items in a not-very-informative and yet absolute unit of a tooltip.

@caleboleary
Copy link

We faced this issue again :) I wish I could either:

  1. disable tooltip, or
  2. feed the component my own tooltip text, be it static or dynamic. In this case, I can provide informative text rather than listing potentially hundreds of items in a not-very-informative and yet absolute unit of a tooltip.

I'd like both of these options. Doing a state select right now, would love to show the state abbrevs in the tooltip instead of their full names, but want full names in the select.

@gdoohen1 gdoohen1 self-assigned this Aug 5, 2021
@gdoohen1 gdoohen1 added enhancement New feature or request in progress labels Aug 5, 2021
SeanGroff pushed a commit that referenced this issue Aug 6, 2021
## [5.3.0](v5.2.4...v5.3.0) (2021-08-06)

### Features

* 🎸 Added showTooltip and tooltipText props to MultiSelect ([8bc967d](8bc967d)), closes [#313](#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants