Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormMultiSelect styling differences with other components #30

Closed
ghost opened this issue Dec 21, 2020 · 2 comments · Fixed by #32
Closed

SQFormMultiSelect styling differences with other components #30

ghost opened this issue Dec 21, 2020 · 2 comments · Fixed by #32
Assignees
@SeanGroff
Labels
bug Something isn't working question Further information is requested released

Comments

@ghost
Copy link

ghost commented Dec 21, 2020 •
edited by ghost
Loading

image
image

It looks like the styling is not being bundled for the multi select component.

Edit:
After looking into the component it looks like there is not any styles being applied for font size. I will wait to here back from Nemeth on what should be done.
https://github.com/SelectQuoteLabs/SQForm/pull/14/files - PR to add the component.
@ghost ghost added the question Further information is requested label Dec 21, 2020
@ghost ghost changed the title SQFormMultiSelect SQFormMultiSelect styling conflicts with other components Dec 21, 2020
@ghost ghost changed the title SQFormMultiSelect styling conflicts with other components SQFormMultiSelect styling differences with other components Dec 21, 2020
@ghost
Copy link
Author

ghost commented Dec 21, 2020

When hovering over the selected items we also get a tooltip with the Keys. I don't think that is probably desirable.
image

@SeanGroff SeanGroff self-assigned this Dec 21, 2020
@SeanGroff SeanGroff added the bug Something isn't working label Dec 21, 2020
SeanGroff pushed a commit that referenced this issue Dec 22, 2020
fix: 🐛 Tooltip now displays the option label rather than value
40d1e42 
✅ Closes: #30
SeanGroff pushed a commit that referenced this issue Dec 22, 2020
fix: 🐛 Fixs dropdown font size and renders empty label - -
2308d55 
Fixes*

✅ Closes: #30
@SeanGroff SeanGroff mentioned this issue Dec 22, 2020
Merged
github-actions bot pushed a commit that referenced this issue Dec 22, 2020
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
0cbea9a 
### [2.0.1](v2.0.0...v2.0.1) (2020-12-22)

### Bug Fixes

* 🐛 Fixs dropdown font size and renders empty label - - ([2308d55](2308d55)), closes [#30](#30)
* 🐛 Reading the dirty state on load to disable submit/next ([60034e2](60034e2)), closes [#26](#26)
* 🐛 Tooltip now displays the option label rather than value ([40d1e42](40d1e42)), closes [#30](#30)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanGroff SeanGroff

Labels
bug Something isn't working question Further information is requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 30 SelectQuoteLabs/SQForm
1 participant
@SeanGroff