Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormDatePicker not showing error message until we click on the datepicker again #127

Closed
saadurrehman-selectquote opened this issue Mar 15, 2021 · 2 comments · Fixed by #143
Closed

SQFormDatePicker not showing error message until we click on the datepicker again #127

saadurrehman-selectquote opened this issue Mar 15, 2021 · 2 comments · Fixed by #143
Assignees
@caleboleary
Labels
released

Comments

@saadurrehman-selectquote
Copy link
Contributor

https://www.loom.com/share/1a96b6a0ee35492b8d273dcc45f35266
SQFormDatePicker not showing error message until we click on the datepicker again, as i explained in the loom video
@caleboleary
Copy link

+1 https://www.loom.com/share/ed06b59c924447e782aa8daf072ff960

@caleboleary caleboleary self-assigned this Mar 18, 2021
caleboleary pushed a commit that referenced this issue Mar 18, 2021
fix: 🐛 run date validation on date picker window close
4088b30 
Date validation was only running on blur of the text element, meaning if
you only used the window, it didn't validate until you focused and
blured the text input or tried to submit. Used setTouched to remedy
this.

✅ Closes: #127
This was referenced Mar 18, 2021
Merged
Closed
SeanGroff pushed a commit that referenced this issue Mar 22, 2021
@semantic-release-bot
chore(release): 4.2.4 [skip ci]
c348325 
### [4.2.4](v4.2.3...v4.2.4) (2021-03-22)

### Bug Fixes

* 🐛 run date validation on date picker window close ([4088b30](4088b30)), closes [#127](#127)
@SeanGroff
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caleboleary caleboleary

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 run date validation on date picker window close SelectQuoteLabs/SQForm
3 participants
@SeanGroff @caleboleary @saadurrehman-selectquote