Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormMultiSelect tooltip values & field values sorted differently #113

Closed
caleboleary opened this issue Mar 8, 2021 · 1 comment · Fixed by #116
Closed

SQFormMultiSelect tooltip values & field values sorted differently #113

caleboleary opened this issue Mar 8, 2021 · 1 comment · Fixed by #116
Assignees
@codyarose
Labels
bug Something isn't working in progress released

Comments

@caleboleary
Copy link

Screen Shot 2021-03-08 at 1 18 40 PM

This was found by one of the QA testers on one of our projects.

When selecting multiple values in a SQFormMultiSelect drop down, the tooltip that displays when you hover will list your selections in the order they were clicked in, while the field itself will list selected options in order as they appear in the list.

In the above screenshot (taken in the storybook), I selected "Joe, Jessica, Jane, Jack" in that order, and that reflects in the tooltip but not the field itself.
@caleboleary caleboleary added the bug Something isn't working label Mar 8, 2021
codyarose pushed a commit that referenced this issue Mar 9, 2021
fix: 🐛 make multiselect renderValue and tooltip order match
33db1dd 
Standardize the way the selected options are rendered in the tooltip and
Select renderValue prop

✅ Closes: #113
@codyarose codyarose self-assigned this Mar 9, 2021
@codyarose codyarose mentioned this issue Mar 9, 2021
Merged
SeanGroff pushed a commit that referenced this issue Mar 12, 2021
@semantic-release-bot
chore(release): 4.1.2 [skip ci]
332cc75 
### [4.1.2](v4.1.1...v4.1.2) (2021-03-12)

### Bug Fixes

* 🐛 make multiselect renderValue and tooltip order match ([33db1dd](33db1dd)), closes [#113](#113)
@SeanGroff
Copy link
Contributor

🎉 This issue has been resolved in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyarose codyarose

Labels
bug Something isn't working in progress released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 make multiselect renderValue and tooltip order match SelectQuoteLabs/SQForm
3 participants
@SeanGroff @caleboleary @codyarose