Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(envoy): refactoring and optimising the components that build envoy config #6119

Merged
merged 19 commits into from
Dec 5, 2024
Merged

refactor(envoy): refactoring and optimising the components that build envoy config #6119

merged 19 commits into from
Dec 5, 2024

Conversation

driev
Copy link

@driev driev commented Nov 29, 2024 •
edited
Loading

What this PR does / why we need it:

This aims to simplify the envoy incremental code, by removing some iteration and increasing the "locality" of function calls.

Which issue(s) this PR fixes:

Fixes # INFRA-1420

TODO:

@driev driev requested review from sakoush and lc525 as code owners November 29, 2024 11:52
@driev driev marked this pull request as draft November 29, 2024 16:51
@driev driev changed the title refactor(envoy): removing some extra iteration and improving a test refactor(envoy): removing some extra iteration Nov 29, 2024
@driev driev added the v2 label Dec 2, 2024
@driev driev changed the title refactor(envoy): removing some extra iteration refactor(envoy): refactoring and optimising the components that build envoy config Dec 4, 2024
@driev driev marked this pull request as ready for review December 4, 2024 15:36
@sakoush sakoush removed the request for review from lc525 December 5, 2024 14:24
sakoush
sakoush approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. some minor comments.

scheduler/pkg/envoy/xdscache/seldoncache.go Show resolved Hide resolved
scheduler/pkg/envoy/xdscache/seldoncache.go Outdated Show resolved Hide resolved
scheduler/pkg/envoy/resources/resource.go Outdated Show resolved Hide resolved
scheduler/pkg/envoy/xdscache/seldoncache.go Outdated Show resolved Hide resolved
@driev driev merged commit c431854 into SeldonIO:v2 Dec 5, 2024
3 checks passed
@driev driev deleted the INFRA-1420/refactor-incremental-processor-part-1 branch December 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakoush sakoush sakoush approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driev @sakoush