-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor trace b3 propagate #1445
Executor trace b3 propagate #1445
Conversation
Hi @andrewshaoyu. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
move the initTracing to tracing package, add newTracer test case |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andrewshaoyu can you rebase to fix conflict? |
@andrewshaoyu also check lint error - can you make sure you run |
New changes are detected. LGTM label has been removed. |
/ok-to-test |
Tue Feb 18 10:45:27 UTC 2020 impatient try |
Tue Feb 18 10:45:44 UTC 2020 impatient try |
/test integration |
Tue Feb 18 10:53:22 UTC 2020 impatient try |
executor extract the b3 header