Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor trace b3 propagate #1445

Merged
merged 7 commits into from
Feb 18, 2020

Conversation

andrewshaoyu
Copy link
Contributor

executor extract the b3 header

@seldondev
Copy link
Collaborator

Hi @andrewshaoyu. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

executor/main.go Outdated Show resolved Hide resolved
executor/api/tracing/trace.go Outdated Show resolved Hide resolved
@andrewshaoyu
Copy link
Contributor Author

move the initTracing to tracing package, add newTracer test case

@seldondev seldondev added size/L and removed size/M labels Feb 15, 2020
@ukclivecox
Copy link
Contributor

/approve

@seldondev seldondev added the lgtm label Feb 18, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

@andrewshaoyu can you rebase to fix conflict?

@ukclivecox
Copy link
Contributor

@andrewshaoyu also check lint error - can you make sure you run make test in executor folder

@seldondev seldondev removed the lgtm label Feb 18, 2020
@seldondev
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@ukclivecox
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Tue Feb 18 10:45:27 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1445/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1445 --build=4

@seldondev
Copy link
Collaborator

Tue Feb 18 10:45:44 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1445/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1445 --build=3

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Feb 18 10:53:22 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1445/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1445 --build=5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants