Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test models to output logits and work with default loss functions #975

Merged

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Oct 12, 2023

Fixes the issue described here: #968 (comment)

I opted to change both models to output logits (for consistency), this requires keeping from_logits=True for the tensorflow loss function (default is False).

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #975 (6aca56d) into master (7f1c2f3) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          74       74           
  Lines        8834     8834           
=======================================
  Hits         7530     7530           
  Misses       1304     1304           
Files Coverage Δ
alibi/explainers/tests/test_simiarlity/conftest.py 100.00% <ø> (ø)

@jklaise jklaise merged commit 676e548 into SeldonIO:master Oct 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant