Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows and MacOS CI on Python 3.11 #947

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Jul 17, 2023

Seems that torch support is there and since we only run one version on each non-linux platform we might as well run on the latest supported.

@jklaise
Copy link
Contributor Author

jklaise commented Jul 17, 2023

Requires investigation why torch 1.x is being pulled in since we support 2.x now.

@jklaise
Copy link
Contributor Author

jklaise commented Jul 17, 2023

Ah there's a bug in extras_require as torch version hasn't been bumped. Will resolve here and in alibi-detect.

Edit: fixed here #950

@jklaise jklaise force-pushed the dev/windows-mac-ci-3.11 branch from 87a0655 to 9477b83 Compare July 17, 2023 11:13
@jklaise jklaise force-pushed the dev/windows-mac-ci-3.11 branch from 9477b83 to 45d1140 Compare July 17, 2023 12:50
@jklaise
Copy link
Contributor Author

jklaise commented Jul 17, 2023

Fixed another bug with missing forwardref causing an import error when ray isn't present: 17b7267

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #947 (45d1140) into master (17b7267) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          74       74           
  Lines        8832     8832           
=======================================
  Hits         7528     7528           
  Misses       1304     1304           

@jklaise
Copy link
Contributor Author

jklaise commented Jul 17, 2023

Tests passed so will merge for 3.11 testing.

@jklaise jklaise merged commit 5445ad2 into SeldonIO:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant