Separate code quality step and only run on 3.10

[jklaise]

It makes sense to run lints and type-checking only on the latest supported version (currently 3.10) as this will unblock improvement in tooling (e.g. see #874).

[jklaise]

Ironically using code-quality as a pre-requisite for the test jobs takes overall longer just because of the length of time needed to install our dependencies. Perhaps better to remove the pre-requisite so that jobs can start asap (they would be cancelled if code-quality fails? @ascillitoe

[codecov]

Codecov Report

Merging #925 (9c7fbf0) into master (d37c724) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
- Coverage   85.28%   85.21%   -0.07%     
==========================================
  Files          74       74              
  Lines        8832     8792      -40     
==========================================
- Hits         7532     7492      -40     
  Misses       1300     1300              

see 7 files with indirect coverage changes

[ascillitoe]

Sorry late to this. I agree that it makes sense to separate, and also OK to remove the pre-requisite since as you say, the test jobs will be cancelled anyway if code-quality fails.

[jklaise]

@ascillitoe I was actually wrong, the test jobs wouldn't be cancelled (perhaps there is a setting). Currently they only get cancelled if one of the tests in the build fails.