Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook to account for changed pandas value_counts method… #910

Merged

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Apr 17, 2023

… behaviour

Resolves #909. Uses a version-agnostic code to rename the column index to left. Note that this reduces to a no-op in 2.x as the column is already called left, fortunately the code doesn't throw an error if a column name doesn't exist which allows us to have version-agnostic code here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jklaise jklaise merged commit 92f808a into SeldonIO:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

permutation_importance_classification_leave.ipynb notebook failing
1 participant