Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-custom_exit_code to not flag empty notebook test suite as … #728

Merged

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Jul 29, 2022

…a CI failure

Resolves #647. @ascillitoe if happy with implementation I'll open an identical PR for alibi-detect.

@jklaise jklaise requested a review from ascillitoe July 29, 2022 14:21
Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #728 (9aec082) into master (f66d5ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         105      105           
  Lines       11794    11794           
=======================================
  Hits         9561     9561           
  Misses       2233     2233           
Impacted Files Coverage Δ
alibi/explainers/anchors/anchor_base.py 92.70% <0.00%> (ø)
alibi/explainers/anchors/anchor_text.py 94.44% <0.00%> (ø)
alibi/explainers/anchors/anchor_image.py 93.12% <0.00%> (ø)
alibi/explainers/anchors/anchor_tabular.py 90.17% <0.00%> (ø)

@jklaise jklaise merged commit 05f44dc into SeldonIO:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress notebook CI test failure when all tests are skipped
2 participants