Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect empty anchor justification #701

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Jun 15, 2022

The second point in the current version of the docs should not be possible because if it was (empty anchor returned and the prediction always changes, regardless of perturbation), the empty anchor would have precision ~0 and hence would not be returned in the first place. In fact, if the prediction does change a lot regardless of the perturbation, the data point is likely near the decision boundary and the algorithm will try longer and longer anchors to find something that satisfies the precision threshold.

@jklaise jklaise requested a review from RobertSamoilescu June 15, 2022 10:20
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #701 (94c84b2) into master (e5814a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files         105      105           
  Lines       11790    11790           
=======================================
  Hits         9497     9497           
  Misses       2293     2293           

Copy link
Collaborator

@RobertSamoilescu RobertSamoilescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jklaise jklaise merged commit 28e4f46 into SeldonIO:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants