Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DateTimeImmutable #1928

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Deprecate DateTimeImmutable #1928

merged 1 commit into from
Dec 5, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 21, 2024

Fixes #1926

@ruudk ruudk mentioned this pull request Nov 21, 2024
Closed
@Seldaek Seldaek merged commit a258e4f into Seldaek:main Dec 5, 2024
@Seldaek Seldaek added this to the 3.x milestone Dec 5, 2024
@Seldaek
Copy link
Owner

Seldaek commented Dec 5, 2024

Thanks

@Seldaek Seldaek mentioned this pull request Dec 5, 2024
Open
@InvisibleSmiley
Copy link
Contributor

FYI, citing https://semver.org/

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated.

@ruudk ruudk deleted the date-time-immutable branch December 11, 2024 12:14
@Seldaek
Copy link
Owner

Seldaek commented Dec 11, 2024

Not sure what you're trying to say?

@InvisibleSmiley
Copy link
Contributor

New version should have been 3.9.0, not 3.8.1

@Seldaek
Copy link
Owner

Seldaek commented Dec 11, 2024

Ah I see. Yeah that was a mistake rushing this release while sitting at SymfonyCon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

Rename Monolog\DateTimeImmutable to something else, e.g. JsonSerializableDateTimeImmutable
3 participants
@ruudk @Seldaek @InvisibleSmiley