fix: adding support for dynamic mounting dir #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This PR fixes a bug in setting the top level directory for GIT_CONFIG_VALUE_0, which is used to mark a git directory as "safe."
The conditional to set this env was
git rev-parse --show-toplevel > /dev/null || /iac
.When mounting a working dir that is different from /iac and encountering an error with
git rev-parse
, the base dir was incorrectly assigned "/iac." This caused logging git-related information to fail because git would detect "dubious ownership" of a directory not marked "safe."The fix is to make the 'or' condition dynamic to the mounted volume path.
Pull Request Checklist
Thank you for submitting a contribution to our project!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:
Don't forget our more detailed contribution guidelines
here.