Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support scan_ function hooks #267

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 2, 2023

Contributor Comments

This allows you to register hooks against the generated scan_ functions, meaning that you can now arbitrarily register and run hooks against a repo or set of repos without needing to create a valid Command, you can simply write a hook for scan_ansible and then run scan_ansible against a repo to have the hook run, generate logs, and centralize them using your existing fluent-bit configs.

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla requested a review from ChiefHolland August 2, 2023 20:11
docs/Hooks/index.rst Outdated Show resolved Hide resolved
@JonZeolla JonZeolla enabled auto-merge (squash) August 3, 2023 19:00
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit 7eeb310 into main Aug 4, 2023
@JonZeolla JonZeolla deleted the add-scan_-hook-support branch August 4, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants