Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removed kics references from terraform docs #240

Merged
merged 1 commit into from
Feb 23, 2023
Merged

docs: removed kics references from terraform docs #240

merged 1 commit into from
Feb 23, 2023

Conversation

ChiefHolland
Copy link
Contributor

Contributor Comments

KICS is no longer used for Terraform in easy_infra. References to it were removed from RTD.

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

ChiefHolland
ChiefHolland commented Feb 22, 2023
View reviewed changes
Copy link
Contributor Author

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed KICS references from RTD to reflect the removal of that tool from easy_infra.

@ChiefHolland ChiefHolland marked this pull request as ready for review February 22, 2023 19:45
JonZeolla
JonZeolla approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit d9f33dd into main Feb 23, 2023
@JonZeolla JonZeolla deleted the remove-kics-reference branch February 23, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonZeolla JonZeolla JonZeolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiefHolland @JonZeolla