Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Update for the new linters #222

Merged
merged 25 commits into from
Nov 18, 2022
Merged

fix(ci): Update for the new linters #222

merged 25 commits into from
Nov 18, 2022

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Nov 15, 2022

Contributor Comments

fix(ci): Update for the new linters

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla marked this pull request as draft November 15, 2022 17:48
@JonZeolla JonZeolla requested a review from digeseiso November 15, 2022 17:50
@JonZeolla
Copy link
Member Author

In working on this I found that isort was incorrectly characterizing our first pretty good as third party previously. Now my local environment and the remote environment should agree on the correct state.

@JonZeolla JonZeolla marked this pull request as ready for review November 18, 2022 00:09
@JonZeolla JonZeolla closed this Nov 18, 2022
@JonZeolla JonZeolla reopened this Nov 18, 2022
@JonZeolla JonZeolla enabled auto-merge (squash) November 18, 2022 13:46
@JonZeolla JonZeolla mentioned this pull request Nov 18, 2022
4 tasks
@JonZeolla JonZeolla merged commit 7a59c26 into main Nov 18, 2022
@JonZeolla JonZeolla deleted the fix-ci branch November 18, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants