Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move to env files #213

Merged
merged 6 commits into from
Oct 31, 2022
Merged

ci: Move to env files #213

merged 6 commits into from
Oct 31, 2022

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Oct 19, 2022

Contributor Comments

This moves us to env files in our pipeline instead of using set-output. The prior approach was deprecated by GitHub Actions on Oct 11, 2022. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla marked this pull request as ready for review October 19, 2022 12:40
@JonZeolla JonZeolla requested a review from digeseiso October 19, 2022 12:40
@JonZeolla JonZeolla enabled auto-merge (squash) October 19, 2022 12:41
@JonZeolla JonZeolla merged commit 7983028 into main Oct 31, 2022
@JonZeolla JonZeolla deleted the move-to-env-files branch October 31, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants