Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

fix typo in Triplet.h line 352 #407

Merged
merged 1 commit into from
May 30, 2024
Merged

fix typo in Triplet.h line 352 #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SDL/Triplet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ namespace SDL {
float drt_InSeg = rtMid - rtIn;
float dz_InSeg = zMid - zIn;
float dr3_InSeg =
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn + zIn);
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn * zIn);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would can potentially affect BBB T3s: the value of dr3_InSeg was slightly larger with the bug, which meant a slightly larger z selection window based on the track direction due to a larger component accounting for the multiple scattering. Realistically only T3s starting in barrel layer 1 may show something, but it looks like it was not visible even there.


float coshEta = dr3_InSeg / drt_InSeg;
float dzErr = (zpitchIn + zpitchOut) * (zpitchIn + zpitchOut) * 2.f;
Expand Down