This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
updates to get module maps used as ES products jointly with CMSSW #355
Merged
+1,046
−970
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
810f844
define values derived from Acc only when it's expected to be defined
slava77devel 0efcf09
split heavier methods from Module.h to ModuleMethods.h
slava77devel f75a8af
make module parseIs methods static
slava77devel 7962508
make loadMaps static (consider moving it out of the LST class to redu…
slava77devel 73667f9
make modules data pointers const
slava77devel 4c574d1
drop emacs temp files
slava77devel 01760bf
check both CMSSW_BASE and CMSSW_RELEASE_BASE if available
slava77devel ce85856
initialize derived quantities
slava77devel 08743db
move constants away from global namespace to SDL (unless already in a…
slava77devel bd004dd
sdlLayers before connectedPixels consistently in modules and buffers
slava77devel d91352b
clang-format
slava77devel 2340fed
clang-tidy
slava77devel 412596f
describe lst_headers variant of the LST external
slava77devel 7b58aa0
use device/TDev template argument trait for Buf instead of accelerato…
slava77devel ac98d78
clang-format and clang-tidy
slava77devel 817c1c5
clang-fix
slava77devel 0aa37d2
refactor LST ES-related calls to be usable by CMSSW directly
slava77devel 5487bf0
cleanup unused var
slava77devel 87ad3de
clang compile fix
slava77devel eca2c59
move data buffer templates from Acc to Dev to be more in line with al…
slava77devel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor LST ES-related calls to be usable by CMSSW directly
commit 0aa37d2be2c6fe0d34a3e1076358b472e6d18ed6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of defining this, if
trackLooperDir()
is used almost everywhere in the following? Was it meant to be a short version but then it was forgotten?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed now