-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 27313/remove resources panel #2064
base: sheets-viewer-final
Are you sure you want to change the base?
Feature/sc 27313/remove resources panel #2064
Conversation
…hub.com/Sefaria/Sefaria-Project into feature/sc-27313/remove-resources-panel
@@ -0,0 +1,520 @@ | |||
import Component from "react-class"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When moving the logic here from static/js/Sheet.jsx
did you copy-paste or use git cp
? That would preserve the file's history, as opposed to showing that you wrote everything with the current commit date :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about 'git cp'. I'm wondering if I should try reverting the commit that moved the SheetContent component into its own file and then using 'git cp'. I'm worried though that this might cause a mess downstream in the other branches that are dependent on SheetContent.jsx. What do you think?
Description
In this PR, I removed the resources panel from the sheets viewer (and editor) as well as moving code that would no longer be used or relevant given that the resources panel is no longer part of the sheets viewer (and editor).
Code Changes
masterPanelMode === "Sheet"
cases have been removed. I removed several components no longer needed: AboutSheet, SheetToolsList, SheetNodeConnectionTools, MySheetsList, PublicSheetsList and AboutSheetButtons. Some of these components' code was copied over and is being re-used in components in other PRs for the Sheets Viewer. One particular component, ShareBox, has the exact same functionality that I need for the new Sheets Viewer, and so all I had to do was modify its prop MasterPanelSheetId to SheetId.highlightedNode
andhighlightedRefs
based on the sheet segment click. This allowed me to remove the function setSheetHighlight in ReaderApp and the functions openSheetConnectionsInPanel and closeSheetConnectionsInPanel in ReaderPanel as they are no longer called.