Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] PushCase README standardization edits #593

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Aug 9, 2024

Description

The other enclosures included in our repo are just matter-of-fact presentations of their design.

My edits strip out the designer's personal references to external social media links, donation addr, and store url.

A later TODO: fully standardize ALL enclosure READMEs in the repo via a formal template (see #592).


This pull request is categorized as a:

  • Documentation

@jdlcdl
Copy link

jdlcdl commented Aug 9, 2024

ACK

Nice catch, I agree and note:

  • Now I can follow another fellow dev on github ;)
  • And can find their X.com account from there,
  • And can get to their online store from there.

So no linkability was lost, just indirected in a clear-to-find way. This is much more appropriate for a foss project.

@newtonick
Copy link
Collaborator

Agree with the changes suggested and support moving enclosures eventually to a dedicated repo in the future.

@newtonick newtonick merged commit e50f234 into SeedSigner:dev Aug 16, 2024
2 checks passed
@kdmukai kdmukai deleted the pushcase_readme_edits branch September 2, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants