Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Rename dir for the "lookScrews!" enclosure docs #588

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Aug 7, 2024

Description

Renames the enclosure dir to omit the exclamation point in the file path and match the other enclosures' naming convention (lowercase, underscore separator).

This pull request is categorized as a:

  • Documentation

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

@jdlcdl
Copy link

jdlcdl commented Aug 9, 2024

ACK

(just reviewed changes visually, nothing 3d printed; actually content was not changed.)
"S" became "s_" and "!" was removed from filenames.

@newtonick
Copy link
Collaborator

ACK

@newtonick newtonick merged commit 794c25c into SeedSigner:dev Aug 16, 2024
2 checks passed
@kdmukai kdmukai deleted the look_screws_copy_edits branch September 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants