Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception when attempting to sign message for custom derivation address #518

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

BamaHodl
Copy link
Contributor

@BamaHodl BamaHodl commented Jan 8, 2024

Description

This PR fixes the unhandled exception when trying to sign a message from a custom derivation path. The intention in the original code was to show a NotYetImplementedView with a custom text message describing the unsupported feature, however it was implemented as a raise of the view instead of a redirect, as well as a bad initialization of the view (bad parameters).

Screenshot from 2024-01-08 10-49-11

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

@newtonick
Copy link
Collaborator

ACK and tested. Congrats @BamaHodl on your first SeedSigner merged PR! I appreciate the time put into the PR.

@newtonick newtonick merged commit 558e6c3 into SeedSigner:dev Feb 12, 2024
@BamaHodl
Copy link
Contributor Author

ACK and tested. Congrats @BamaHodl on your first SeedSigner merged PR! I appreciate the time put into the PR.

Thank you! Very proud to have been able to contribute to this project.

@BamaHodl BamaHodl deleted the SignMessageError branch July 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants