-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limited support for electrum segwit seeds #513
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c1d320f
Add limited support for electrum segwit seeds
89f6cec
making suggested changes for electrum derivation path and removing on…
eaa29ab
derivation path override to make address verifiction work for electru…
1f0a4dd
since EncodeQR generates the seed internally for xpub export, we have…
289b382
pass seed to EncodeQR instead of mnemonic and passphrase to simplify
656110b
Revert "pass seed to EncodeQR instead of mnemonic and passphrase to s…
f8aca10
export correct xpub version bytes for electrum seeds
8f0a8fe
Merge branch 'SeedSigner:dev' into PRChanges
BamaHodl 40520f8
integrating PR review recommendations for electrum seed support
8c9fd5c
display warning screen before user inputs electrum seed to notify som…
1820997
disabled BIP85 child seeds for electrum seeds since it doesn't apply
2355c53
updating docs to elaborate on current Electrum seed support and limit…
ce9113f
fix bad paste in unverified address deriv path
0fc3ce4
merging main upstream repo into fork
8a83f32
remove unneccessary include
c0f1ad6
small cleanup
b430d50
pass sig_type to BaseXpubQrEncoder so that it can get correct version
d483864
fixing merge conflict with new test in test_flows_tools.py
a28f162
Update electrum.md
BamaHodl 4ea2d72
more explicit about which electrum seeds supported in Advanced option…
46061c5
correcting electrum doc to match change in option name
75d9f5f
make sure to use the correct list for script_types
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# SeedSigner Electrum seed phrase support | ||
|
||
SeedSigner supports loading of [Electrum's Segwit seed phrases](https://electrum.readthedocs.io/en/latest/seedphrase.html#electrum-seed-version-system). This is considered an Advanced feature that is disabled by default. | ||
|
||
To load an Electrum Segwit seed phrase, first enable Electrum seed support in Settings -> Advanced -> Electrum seed support. After this option is enabled, the user will now be able to enter an Electrum seed phrase by selecting "Enter Electrum seed" in the Load Seed screen. | ||
|
||
Some SeedSigner functionality is deliberately disabled when using an Electrum mnemonic: | ||
|
||
- BIP-85 child seeds | ||
- Not applicable for Electrum seed types | ||
- SeedQR backups | ||
- Since Electrum seeds are not supported by other SeedQR implementations, it would be dangerous to use SeedQR as a backup tool for Electrum seeds and is thus disabled | ||
- Custom derivations | ||
- Hard coded derivation path and script types in SeedSigner to match Electrum wallet software. These are m/0h for single sig and m/1h for multisig | ||
- User-chosen custom derivations are thus not supported for Electrum seeds |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand not doing this for bip85 because the user might NOT be expecting a bip39 mnemonic. But wondering why no custom derivation for electrum seeds??? Is it about electrum not using standard derivation paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Electrum doesn't use standard derivation paths, or let users edit them, they are basically hardcoded based on the seed type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to explicitly add the hard coded derivations in SeedSigner in this document.
Suggestion: