Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs update] Manual installation steps minor edits #509

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Nov 19, 2023

Description

  • Adds additional time guidance for long-running setup tasks.
  • Removes the virtualenv

Rationale: virtualenvs are only useful when multiple python projects run on the same machine. Instead we just directly install pip dependencies into the installed python3.

This pull request is categorized as a:

  • Documentation

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

@jdlcdl
Copy link

jdlcdl commented Nov 19, 2023

I like less to do w/o virtualenv, besides it's sort of a preference that devs will know to do, and how they prefer to do it if they're aware of it.

Question though: were any "sudo"s necessary that might not have made it into these docs changes?

@kdmukai
Copy link
Contributor Author

kdmukai commented Nov 19, 2023

@jdlcdl The only altered commands are the python3 -m pip calls instead of running pip from within the virtualenv, but those do not require sudo (in general sudo + pip only creates trouble).

@jdlcdl
Copy link

jdlcdl commented Dec 2, 2023

ACK

This worked for me today... but I always removed the recently suggested /swapfile as root (I think to build numpy w/ less than 1gb ram)

@@ -303,13 +258,9 @@ sudo rm /var/swap

## Manually start the SeedSigner code
```bash
# activate the virtualenv if you haven't already
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 lines above here:
sudo rm /var/swap becomes sudo rm /var/swap /swapfile

@newtonick
Copy link
Collaborator

ACK, these changes worked in my brief testing.

@newtonick newtonick merged commit 5667cee into SeedSigner:dev Feb 13, 2024
1 check passed
@kdmukai kdmukai deleted the patch-6 branch September 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants