[Enhancement] Additional edge padding for Warning Screen body text #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Current Warning Screens use the standard
GUIConstants.EDGE_PADDING
for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.The fix
Double the default edge padding for Warning Screens.
Before / After
(unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)
This change affects all Warning Screens, so you must regenerate screenshots to see the changes.
Additional changes
ErrorView
Follow-up steps
If merged, generate new screenshots and update https://github.com/SeedSigner/seedsigner-screenshots