-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeedSigner Icons v2 #423
SeedSigner Icons v2 #423
Conversation
- Renamed `seedsigner-glyphs.otf` to `seedsigner-icons.otf` - Updated `seedsigner-icons.otf` - Renamed `SeedSignerCustomIconConstants` to `SeedSignerIconConstants` - Updated `SeedSignerCustomIconConstants` names and Unicode values in src/seedsigner/gui/components.py
src/seedsigner/gui/components.py
Outdated
@@ -28,7 +28,7 @@ class GUIConstants: | |||
REGTEST_COLOR = "#00caf1" | |||
|
|||
ICON_FONT_NAME__FONT_AWESOME = "Font_Awesome_6_Free-Solid-900" | |||
ICON_FONT_NAME__SEEDSIGNER = "seedsigner-glyphs" | |||
ICON_FONT_NAME__SEEDSIGNER = "seedsigner-icons" | |||
ICON_FONT_SIZE = 22 | |||
ICON_INLINE_FONT_SIZE = 24 | |||
ICON_LARGE_BUTTON_SIZE = 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your LargeButtonScreen where your latest icon set appears smaller than before, you might play with resizing this from 36 to something bigger.
I don't know what bad side-effects this might have. @kdmukai will probably know better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This morning I had a chance, with fresh eyes and coffee, to really take a look at these changes. I hear "Try a different color shirt with those!" almost daily, so forgive me for not having noticed the improvements at first glance yesterday. On a large desktop screen with 2 browsers open side by side: ...it was much easier for me to take my time and appreciate your fine work. @kdmukai really did wonderful work with the screenshots_generator, they're so useful: like acceptance testing for folks with a sense of style (who can help folks like me picking clothes). Over time, we'll do better to keep these updated and get more screens working. |
Haha. Thank you for the kind words, and for the before and after. 🙏 I added links and thumbnails to the before and after at the top. |
Omigosh this makes me so happy to see the screenshot generator revived and being so useful!! Looks like the |
I'm aware of this warning and I have not yet tracked it down. Otherwise, on the pi from where you ran it, there should be a ../seedsigner-screenshots directory with a README.md and many pngs, if it did anything. While I was working on this branch here for @easyuxd to have a tight feedback loop while implementing his new icon set, I made many less-than-ideal hacks just to get these working... to that end. I believe that the screenshots code (everything in
(or for you to do similar during merge) so that this code is removed from this particular pr, but so that it remains available for him to use in order to see his design changes at will. That would afford me the time to do some much needed cleanup, as well, to get feedback from @kdmukai who is sure to have plenty of good ideas, having created it. I suspect it will play well with the recent flow-tests changes. If the @easyuxd, if you'd like help removing the screenshots_generator code from this pr so that its lack of readiness won't delay the rest of this pr, please let me know. |
Thank you! I was looking in the seedsigner repo folder and did not expect it to be written one level higher. |
The one weirdo warning:
was driving me crazy. Turns out that it's from It doesn't do any harm, but is annoying to see the warning. |
tweaks for new easyuxd screenshots
PR SeedSigner#423 with local mocks
…signer into seedsigner-icons-v2
As of cd65820,
All images are being generated (though more could be generated and plenty of organization to do). These look really nice. You probably don't know this, but sometimes I find myself just scrolling up and down these screenshots, thinking "Wow... it really is a nice interface!" p.s. If you notice an initial delay, as if pr 416 got backed-out, it's just that it isnt in this branch yet. |
Yes, there are 4 conflicts currently and they're mostly related to the change of the constant name, you'd want to select your changes and remove the others. However, in the psbt_views.py conflict, there is also a recent bug fix where you want a little of both fixes: your icon constants of course, but the way 'dev' refers to "buttons" instead of "self.buttons" needs to be applied to yours, else a recent bug recently fixed soon returns. |
As of f6c1152, All tests are passing whether run on raspi or desktop. |
8bb6d25 almost brought a tear to my eye. <3 |
@newtonick |
ACK tested viewed before and afters as of d27e9e3. Nice job on the merge conflicts, and especially your latest cleanup-commits, craftsman! |
ACK Tested |
This PR is for a v2.0 update to the SeedSigner Icon Set. @jdlcdl recently brought to my attention that the icon set is in need of an update, as it has not been updated since the v0.5.0 release.
I could use help with additional testing to ensure I didn’t break anything with this change. Especially with icon sizing (it looks like the SeedSigner icons draw smaller than FontAwesome icons). I've outlined a couple of visual defects below.
Huge thanks to @jdlcdl for the help troubleshooting this PR -- it would have been impossible without him. I’ve included his modified version of the @kdmukai screenshot_generator tool. It's hugely useful for testing, with really solid improvements. This can be removed if we don’t want to revive it right now.
Screenshots:
Full list of icons
[SeedSigner Design System (v0.6)]
(https://github.com/easyuxd/seedsigner-design-system#iconography)
Changes:
seedsigner-glyphs.otf
toseedsigner-icons.otf
seedsigner-icons.otf
SeedSignerCustomIconConstants
toSeedSignerIconConstants
SeedSignerIconConstants
names and Unicode values in src/seedsigner/gui/components.pyDefects:
Resolved: New icons draw smaller on the Home Screen grid tiles. I could use help increasing their size to 40x40px.
QR Brightness overlay - New up/down chevrons may have affected padding @overcat