[Enhancement] Live preview speedup #413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due do slower rendering times in SeedSigner OS (full-screen updates are noticeably slower), we need to optimize the
ScanScreen
live preview as much as possible. Currentdev
branch is only rendering the live preview at about 1.6 fps for the live display and 3.1 fps for the QR decoder in SeedSigner OS (see my benchmarking branch to get an onscreen fps display).In my testing, this PR gets a Pi Zero running SeedSigner OS up to about 3.3 fps for the live preview and a coincidental 3.3 fps for the QR decoder.
On Raspi OS, I've seen this same code range from 4.6fps display / 3.8 fps decode to 3.5 fps display / 4.6 fps decode.