[Bugfix] Remove errant import in psbt_screens.py #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK I confirm that importing lzma anything raises ModuleNotFoundError in my custom 3.10 build too. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e9ad26b introduced an unintended
lzmaimport (blame VSCode automatic "quick fix" and a not careful enough visual inspection of diffs on what's being committed).This errant import currently seems to be harmless because:
lzmacompiled in (otherwise those screens would crash on the import).lzmacompiled in.However, with #347 we're custom-compiling python3.10 on Raspi OS. And doing so without
lzmasupport. So the import crashes the python file.