Avoid OS specific function uname() #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is necessary when using the seedsigner-emulator project on Windows for example
|
Am very interested in what you're working on -- can you share more info on what issue this causes? |
|
If you see the project README it explains that it is an emulator for SeedSigner... so if someone wants to see how SeedSigner works and don't have a Raspeberry Pi, it is possible to emulate it on Windows, Linux or Mac. But for Windows, because it doesn't have the |
|
ACK tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary to avoid
AttributeError: module 'os' has no attribute 'uname'when using theseedsigner-emulatorproject on Windows: https://github.com/tadeubas/seedsigner-emulator