-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuse is waiting #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain what's going on there ? I'm having trouble piecing everything together.
src/channel.rs
Outdated
match errno().0 { | ||
libc::EAGAIN => { | ||
// this is u32, think about endian | ||
unsafe { buffer.set_len(0) }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use buffer.clear() instead, which is safe !
Thank you roblabla for this point, I just fix it |
Doesn't |
So just for future reference : this PR is deeply tied with our proprietary daemon and basically allows us (in a somewhat dirty way) to get better performances. It's basically impossible to upstream as-is though. While it certainly is more work, a better way to improve our performances would be fixing zargony#74 and using |
|
Add basic fuse opt parse
No description provided.