Fix dash un-escaping to be applied unconditionally #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a regression test. |
J-M0
requested changes
Sep 8, 2020
According to RFC 4880, 'an implementation MAY dash-escape any line, SHOULD dash-escape lines commencing "From" followed by a space [...]'. Therefore it is necessary to unescape all lines starting with dash-space sequences, and not just these that have a dash following this sequence. Fixes SecurityInnovation#341 Signed-off-by: Michał Górny <[email protected]>
|
Quick question, does your regression test pass on your machine? When I try to test it in a python prompt locally I can't get it to pass. |
J-M0
approved these changes
Sep 8, 2020
|
Well, tests apparently tests pass for me and travis. |
|
Yeah, it passes for me when I run it through tox on my machine, but typing the code into a |
|
Are you copy-pasting it from GitHub's UI? When I do that, I get: Apprently copy-pasting from the actual file works. It seems that github is inserting some weird unicode characters. |
|
Yep, that was it. Friggin unicode. |
J-M0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 4880, 'an implementation MAY dash-escape any line,
SHOULD dash-escape lines commencing "From" followed by a space [...]'.
Therefore it is necessary to unescape all lines starting with dash-space
sequences, and not just these that have a dash following this sequence.
Fixes #341