Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunt Dropdown MaxWidth #671

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Hunt Dropdown MaxWidth #671

merged 1 commit into from
Nov 13, 2024

Conversation

coreyogburn
Copy link
Contributor

Restrict the MRU Queries dropdown on Hunt to be at most as wide as the hunt input. Normal Vue 3 approaches result in the menu displaying under other elements. Attempts to write this without creating a new function failed: 1) you can't reference ref="..." elements directly from bound properties in the HTML, 2) attempting to use $refs in a bound property aren't reactive and will bond to the pre-mounted value of $refs (undefined) and never calculate properly.

Removed unused directives: bottom, three-line, and offset-y.

Restrict the MRU Queries dropdown on Hunt to be at most as wide as the hunt input. Normal Vue 3 approaches result in the menu displaying under other elements. Attempts to write this without creating a new function failed: 1) you can't reference ref="..." elements directly from bound properties in the HTML, 2) attempting to use $refs in a bound property aren't reactive and will bond to the pre-mounted value of $refs (undefined) and never calculate properly.

Removed unused directives: bottom, three-line, and offset-y.
@coreyogburn coreyogburn merged commit 12e4a00 into 2.4/dev Nov 13, 2024
3 checks passed
@coreyogburn coreyogburn deleted the cogburn/hunt-dropdown-width branch November 13, 2024 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants