Account for missing index #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing our machines don't have a mapping specified at /nsm/custom-mappings/ip-descriptions.csv so the index won't exist. MSearch has been refactored to return the first search response error as an error. If we need to support individual response errors in the future we'll cross that bridge when we come to it. The utilhandler has been updated to ignore "no such index" errors as that is not a sign of failure for the IP lookup. We now log that the index was not found before continuing.
jertel
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing our machines don't have a mapping specified at /nsm/custom-mappings/ip-descriptions.csv so the index won't exist.
MSearch has been refactored to return the first search response error as an error. If we need to support individual response errors in the future we'll cross that bridge when we come to it.
The utilhandler has been updated to ignore "no such index" errors as that is not a sign of failure for the IP lookup. We now log that the index was not found before continuing.