2.4.100 #630
Merged
2.4.100 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reyesj2 <[email protected]>
Force OTP, Config Breadcrumbs, Extended Settings
Additional extended props and breadcrumb tweaks
Because we're putting a data table in a data table, we're disabling all the hover effects for a cleaner UI. Updated dateAwareSort to be aware of new date fields and to properly sort non-string fields (such as isEnabled). In the tuning table, I pass the `type` fields through i18n so they're the proper case. Duplicated the logic in findHistoryChange into findOverrideHistoryChange but refactored for the simpler case. We don't need to highlight changes while ignoring source code changes. Added tests.
remove extended setting toggle
add close setting button to top right
…history Overrides Added to Detection History
…stallations through firewall Security-Onion-Solutions/securityonion#13412
…stallations through firewall Security-Onion-Solutions/securityonion#13412
FEATURE: Add SOC Config Quick Link to allow Security Onion Desktop installations through firewall Security-Onion-Solutions/securityonion#13412
When clicking "Tune Detection" on the Alerts page for a YARA rule, the user is now taken to the Detection Source tab. Other engines continue to take the user to the Tuning tab. We're doing this because YARA detections don't support overrides.
…ra-source Tuning YARA Detections
Because new detections let you specify the language and not the engine, some things needed tweaking to apply to both new and existing detections. New regexes were added to validate rules as well as some custom logic in elastalert and suricata to hunt for things tricker than regexes can find. ElastAlert requires an id field be present, checks that the publicId from the DB matches the publicId in the rule, and lastly checks to make sure that there's some logic present by looking for the detection field and ensuring it's not empty. Suricata requires there to be no newlines, that the sid is specified, and that the sid matches the DB publicId. Strelka requires that the identifier is specified, and that the `condition:` header be present. Checking for condition content is a slippery slope because comments might be there complicating things and I don't want to risk a false positive error.
…side-test Added Rule Validator Regex
Rewording error messages
update gofast images; tiered notifications
remove debug log
After syncing community rules, run all the local rules through a sync so they can get any newly configured alerters attached to them. Updated tests for new logic.
…gma-custom Sync Local Rules
support notification only Sigma Detections
notification only adjustments
avoid license error during unit test runs
custom notify sets
use Sigma tags, not detection tags
When tests are run multiple times the state of package level variables are retained. Made some adjustments so the tests still pass in this scenario.
handle single line and multline values
move custom alerters to subgroup
…tests Fixes for running multiple tests
more user interface improvements for duplicated settings
dougburks
approved these changes
Aug 30, 2024
TOoSmOotH
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.