Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestRefreshAiSummaries Intermittent Failures #617

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

coreyogburn
Copy link
Contributor

YAML fields are not reliably parsed in alphabetical nor declaration order. The test now uses a DoAndReturn to verify passed in parameters. The argument is first sorted and then compared for a more reliable test. Also, the comparison will highlight expected vs actual differences now rather than print pointer values.

…rder. The test now uses a DoAndReturn to verify passed in parameters. The argument is first sorted and then compared for a more reliable test. Also, the comparison will highlight expected vs actual differences now rather than print pointer values.
@coreyogburn coreyogburn merged commit 3c4c5aa into 2.4/dev Aug 19, 2024
3 checks passed
@coreyogburn coreyogburn deleted the cogburn/fix-test branch August 19, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants