Fix for Strelka Rule Duplication #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The titleUpdater regex didn't account for comments between the identifier and the opening curly bracket of the rule. Updated the regex so that's no longer a problem. When building a new title for the rule, check against ES to see if the new publicId is taken, if so increment a tailing number up to 10 times before giving up. Updated the UI to report any errors during the duplication request.
jertel
approved these changes
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The titleUpdater regex didn't account for comments between the identifier and the opening curly bracket of the rule. Updated the regex so that's no longer a problem.
When building a new title for the rule, check against ES to see if the new publicId is taken, if so increment a tailing number up to 10 times before giving up.
Updated the UI to report any errors during the duplication request.