IP/Var + Suricata Fixes #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suricata Overrides now show an IP/Var column in the tuning table. The IP validation rules have been expanded to allow for $VARS and !$VARS in addition to IPv4 and IPv6 CIDRs. Hints have been updated to indicate support for vars. Links to where you set those variables have been added to the ip fields. A bug where Suricata was dropping detection Ids on update has been fixed. Now a second update can happen without refreshing the page. Updated tests.
coreyogburn
force-pushed
the
cogburn/suricata-improvements
branch
from
f441876 to
20321f0
Compare
Added data-aid properties to the (now) gear icons that take you to suricata's vars in the config. Updated column definitions to use i18n values.
jertel
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suricata Overrides now show an IP/Var column in the tuning table.
The IP validation rules have been expanded to allow for $VARS and !$VARS in addition to IPv4 and IPv6 CIDRs. Hints have been updated to indicate support for vars. Links to where you set those variables have been added to the ip fields.
A bug where Suricata was dropping detection Ids on update has been fixed. Now a second update can happen without refreshing the page.
Updated tests.